-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): fix acceptance tests #2158
Conversation
@thevilledev Thanks so much for spotting and fixing these issues. The changes look good to me. Awesome work! Going to wait for the CI run to finish and merge if green. |
Happy to help! Do we consider this as a |
Hi @thevilledev, Thank you for fixing this! Could you please do rebase? Once it is done, I will merge this PR into the main branch. Great job! |
Perfect, thanks @arybolovlev. Rebase done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Description
Currently acceptance tests run against Kind are failing as seen on the previous run here. I ran them on my fork as well with the following setups and both failed:
Two issues here:
Error: localhostProfile must be set if seccompProfile type is Localhost
. Fixing it for 1.27 only makes it better for 1.25.This PR addresses the issues as follows:
audit
seccomp profile to.github/config/seccomp-profiles
as documented on k8s docs. Happy to hear input if this is the right place to store these..github/config
for Kind, in which the seccomp profiles directory is mounted upon cluster creation.Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
None
Community Note